Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZAL: ZK Accel Layer #277

Merged
merged 3 commits into from
Apr 10, 2024
Merged

ZAL: ZK Accel Layer #277

merged 3 commits into from
Apr 10, 2024

Conversation

mratsim
Copy link

@mratsim mratsim commented Feb 15, 2024 •
edited
Loading

Implementation of #216. Supercedes #107.

For discussion during meeting, almost done

Description TBD

@mratsim mratsim mentioned this pull request Feb 19, 2024
Closed
2 tasks
@mratsim mratsim changed the title {WIP - Don't merge] ZAL post frontend/backend split [WIP - Don't merge] ZAL post frontend/backend split Feb 19, 2024
@CPerezz CPerezz mentioned this pull request Feb 21, 2024
Closed
CPerezz added a commit that referenced this pull request Feb 21, 2024
@CPerezz
remove: multiexp_serial for halo2curves version
5d15843 
This removes the entire definition of `multiexp_serial` and replaces
it's usage for the `halo2curves` version (which is the same exact one).

This was seen while reviewing #277 and will save the deprecation of the
method and instead will completelly remove it.
@CPerezz CPerezz mentioned this pull request Feb 21, 2024
Merged
ed255
ed255 reviewed Feb 21, 2024
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First round. Will do another round after the engine: &ZalEngine<...> replacing the MsmAccel is implemented.

halo2_backend/src/plonk/prover.rs Outdated Show resolved Hide resolved
halo2_backend/src/poly/ipa/strategy.rs Show resolved Hide resolved
halo2_common/src/arithmetic.rs Outdated Show resolved Hide resolved
halo2_middleware/src/zal.rs Show resolved Hide resolved
halo2_proofs/tests/frontend_backend_split.rs Outdated Show resolved Hide resolved
halo2_middleware/src/zal.rs Outdated Show resolved Hide resolved
@mratsim mratsim changed the title [WIP - Don't merge] ZAL post frontend/backend split [WIP - Don't merge] ZAL: ZK Accel Layer Feb 21, 2024
CPerezz added a commit that referenced this pull request Feb 22, 2024
@CPerezz
remove: multiexp_serial for halo2curves version
b1f43fa 
This removes the entire definition of `multiexp_serial` and replaces
it's usage for the `halo2curves` version (which is the same exact one).

This was seen while reviewing #277 and will save the deprecation of the
method and instead will completelly remove it.
CPerezz added a commit that referenced this pull request Feb 22, 2024
@CPerezz
remove: multiexp_serial for halo2curves version (#282)
6d1dad3 
This removes the entire definition of `multiexp_serial` and replaces
it's usage for the `halo2curves` version (which is the same exact one).

This was seen while reviewing #277 and will save the deprecation of the
method and instead will completelly remove it.
@mratsim mratsim force-pushed the zal-post-pse-split branch 2 times, most recently from 9509f4e to 61a06ed Compare February 23, 2024 14:01
@mratsim mratsim changed the title [WIP - Don't merge] ZAL: ZK Accel Layer ZAL: ZK Accel Layer Feb 26, 2024
@mratsim mratsim marked this pull request as ready for review February 26, 2024 21:36
ed255
ed255 approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@ed255 ed255 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me! I've left a few questions and discussions but they are minor things. I'm approving this already. Next I think we should get at least one more approval (from @CPerezz)

halo2_middleware/src/zal.rs Outdated Show resolved Hide resolved
halo2_middleware/src/zal.rs Show resolved Hide resolved
halo2_middleware/src/zal.rs Show resolved Hide resolved
halo2_proofs/tests/plonk_api.rs Show resolved Hide resolved
@mratsim mratsim requested a review from CPerezz March 29, 2024 16:01
CPerezz
CPerezz approved these changes Apr 10, 2024
View reviewed changes
Copy link
Member

@CPerezz CPerezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks a lot for the great work @mratsim 🫡🫡

Left this in draft.. Sorry for the delay..

@CPerezz CPerezz merged commit 26652ae into privacy-scaling-explorations:main Apr 10, 2024
12 checks passed
@duguorong009 duguorong009 mentioned this pull request Apr 11, 2024
Merged
@jeremyfelder jeremyfelder mentioned this pull request Apr 14, 2024
Open
@adria0 adria0 mentioned this pull request Jun 10, 2024
Closed
@davidnevadoc davidnevadoc mentioned this pull request Sep 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPerezz CPerezz CPerezz approved these changes

@ed255 ed255 ed255 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mratsim @ed255 @CPerezz